Update SmartThings config flow to be entirely UI based#34163
Merged
Conversation
Member
Author
andrewsayre
commented
Apr 13, 2020
balloob
reviewed
Apr 13, 2020
balloob
reviewed
Apr 13, 2020
balloob
approved these changes
Apr 13, 2020
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Looks great! Just a few last comments.
3 tasks
| flow.hass = hass | ||
|
|
||
| result = await flow.async_step_user({"access_token": token}) | ||
| result = await flow.async_step_pat() |
Member
There was a problem hiding this comment.
This way of starting the flow in tests is legacy now. Now we always want to use the core interfaces, hass.config_entries.flow.async_init to start a flow and hass.config_entries.flow.async_configure to continue a flow. Doing that makes the tests more robust.
balloob
added
breaking-change
dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
This change removes the need (and ability) to use the SmartThings Classic mobile application to install the Home Assistant SmartApp. Going forward, the SmartThings integration setup is completed entirely through the web. This only changes how the integration is setup and not any functionality once setup.
Proposed change
The SmartThings integration relies on the user using the SmartThings Classic app to complete the installation of the integration. The ST Classic App is on a path to retirement and this change removes that dependency. Instead, the user is prompted to authorize and install the integration into their SmartThings account through a web-based UI (external flow).
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
New or updated dependencies have been added to
requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum