Skip to content

Improve LG webosTV#34147

Merged
MartinHjelmare merged 7 commits intohome-assistant:devfrom
timmo001:webostv
Apr 14, 2020
Merged

Improve LG webosTV#34147
MartinHjelmare merged 7 commits intohome-assistant:devfrom
timmo001:webostv

Conversation

@timmo001
Copy link
Copy Markdown
Member

@timmo001 timmo001 commented Apr 13, 2020 •
edited
Loading

Proposed change

  • Set media_player supported features based on sound output - Some outputs don't support volume and some only support stepping
  • Adds media_player unique id
  • Adds media_player device class
  • General Cleanup

Type of change

  • New feature (which adds functionality to an existing integration)

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Apr 13, 2020

Hey there @bendavid, mind taking a look at this pull request as its been labeled with a integration (webostv) you are listed as a codeowner for? Thanks!

@timmo001 timmo001 marked this pull request as ready for review April 13, 2020 14:35
@MartinHjelmare MartinHjelmare changed the title LG webosTV Improvements Improve LG webosTV Apr 13, 2020
MartinHjelmare
MartinHjelmare requested changes Apr 13, 2020
View reviewed changes
Comment thread homeassistant/components/webostv/media_player.py Outdated
Comment thread homeassistant/components/webostv/media_player.py Outdated
@timmo001 timmo001 requested a review from MartinHjelmare April 13, 2020 15:26
MartinHjelmare
MartinHjelmare approved these changes Apr 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@timmo001

This comment has been minimized.

Sign in to view
@MartinHjelmare MartinHjelmare merged commit 18478eb into home-assistant:dev Apr 14, 2020
@timmo001 timmo001 deleted the webostv branch April 14, 2020 18:50
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

cla-signed integration: webostv

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timmo001 @MartinHjelmare @homeassistant