Add snapcast latency attribute and service#34126
Conversation
|
Hi @BarrettLowe, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Can someone tell me why I'm getting errors in the codecov/patch check? Looks like it's complaining about files that I didn't touch. Also I think I fixed my cla-error |
MartinHjelmare
changed the title
|
In Line 651 in 4bcceb4 |
Updated how entity services get called - now conforms to most current method
Moved constants into separate file Removed unnecessary logger message Remove unnecessary schemas
Better - use next() Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
|
What's the best way to run the CI tests locally? I'm using the dev container in vscode. Preferably, I could only run the formatting tools on whatever files I've changed for efficiency... Thanks |
|
In vscode I set up the formatter to auto format on save. To run tests I run We also have the script |
4 participants
Proposed change
This allows users to set latency of snapcast devices. This is useful when connecting higher latency devices to the snapcast system. Users can now write automations to adjust the latency of all connected devices if a slow device joins etc.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: