Fix uncaught exceptions in ios#34119
Merged
MartinHjelmare merged 5 commits intohome-assistant:devfrom Apr 17, 2020
Merged
Conversation
probot-home-assistant
Bot
added
core
integration: ios
small-pr
|
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( |
springstan
changed the title
balloob
reviewed
Apr 13, 2020
MartinHjelmare
requested changes
Apr 13, 2020
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
I don't think this is the right solution.
Contributor
Author
|
ok. made much more simple changes. simply added something to the config. much more straightforward now... thanks for the help |
balloob
reviewed
Apr 15, 2020
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Contributor
Author
|
thanks! one more exception and my project is done... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
not breaking
Proposed change
moved the dependency on notify to manifest.json
it was throwing an exception of empty config and i suspect that it
would also happen in real life, so dependency seems a better way
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: