Skip to content

Do not use POWER_WATT for West wind direction#34069

Merged
Quentame merged 1 commit intohome-assistant:devfrom
Quentame:W-is-not-always-POWER_WATT
Apr 12, 2020
Merged

Do not use POWER_WATT for West wind direction#34069
Quentame merged 1 commit intohome-assistant:devfrom
Quentame:W-is-not-always-POWER_WATT

Conversation

@Quentame
Copy link
Copy Markdown
Member

Proposed change

Do not use POWER_WATT for West wind direction.

Fix from PR #33984

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @SukramJ, mind taking a look at this pull request as its been labeled with a integration (homematicip_cloud) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @maddenp, mind taking a look at this pull request as its been labeled with a integration (bom) you are listed as a codeowner for? Thanks!

@Quentame Quentame requested a review from springstan April 11, 2020 23:23
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry my bad 😅

@maddenp
Copy link
Copy Markdown

maddenp commented Apr 11, 2020

I'm actually only knowledgeable about the camera component in the bom integration, but this certainly looks like it corrects the previous misuse of a constant.

@Quentame Quentame merged commit e273ff5 into home-assistant:dev Apr 12, 2020
@Quentame Quentame deleted the W-is-not-always-POWER_WATT branch April 12, 2020 14:59
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants