Skip to content

UniFi - Allow user to configure tracking of specific clients#34065

Closed
Kane610 wants to merge 1 commit intohome-assistant:devfrom
Kane610:unifi-track_specific_clients
Closed

UniFi - Allow user to configure tracking of specific clients#34065
Kane610 wants to merge 1 commit intohome-assistant:devfrom
Kane610:unifi-track_specific_clients

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Apr 11, 2020

Breaking change

Proposed change

Store a list of MAC addresses that can be used to filter what clients that are to be tracked. Upon configuration all client trackers not part of the list will be removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610 Kane610 force-pushed the unifi-track_specific_clients branch from 431bad9 to 9337b98 Compare April 12, 2020 13:05
},
"device_tracker": {
"data": {
"clients_to_track": "Select specific clients to track",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this feature different than disabling entities?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows users to only track the few ones they want and get everything else removed in one easy step.

@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Apr 12, 2020

An alternative solution will be introduced with 0.109 so I'll park this one in the mean time.

@Kane610 Kane610 closed this Apr 12, 2020
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Apr 12, 2020
Kane610 added a commit to Kane610/home-assistant that referenced this pull request Apr 13, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants