Skip to content

Fix vizio brand name in strings.json#34003

Merged
fabaff merged 1 commit intohome-assistant:devfrom
raman325:vizio_fix_branding
Apr 11, 2020
Merged

Fix vizio brand name in strings.json#34003
fabaff merged 1 commit intohome-assistant:devfrom
raman325:vizio_fix_branding

Conversation

@raman325
Copy link
Copy Markdown
Contributor

Proposed change

In an earlier PR I updated the brand name for vizio to VIZIO in the manifest to match their brand guidelines. I did not think at the time to update strings.json but this PR makes that update. Also fixed two spelling errors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fabaff fabaff merged commit 671e324 into home-assistant:dev Apr 11, 2020
@raman325 raman325 deleted the vizio_fix_branding branch April 11, 2020 15:05
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants