Skip to content

Add homekit configuration option to bind to default interface#33999

Merged
bdraco merged 7 commits into
home-assistant:devfrom
bdraco:homekit_zeroconf_bind_default_interface
Apr 12, 2020
Merged

Add homekit configuration option to bind to default interface#33999
bdraco merged 7 commits into
home-assistant:devfrom
bdraco:homekit_zeroconf_bind_default_interface

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 11, 2020

Proposed change

Homekit can fail to be discoverable because the
zeroconf default is to bind to all interfaces
(InterfaceChoice.All). This does not work
on some systems and (InterfaceChoice.Default) which
binds to 0.0.0.0 is needed for homekit zeroconf
to function.

A new option is available for homekit

zeroconf_default_interface: true

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Homekit can fail to be discoverable because the
zeroconf default is to bind to all interfaces
(InterfaceChoice.All).  This does not work
on some systems and (InterfaceChoice.Default) which
binds to 0.0.0.0 is needed for homekit to zeroconf
to function.

A new option is available for homekit

zeroconf_default_interface: true
Comment thread homeassistant/components/homekit/__init__.py Outdated
Comment thread homeassistant/components/homekit/__init__.py Outdated
bdraco and others added 5 commits April 12, 2020 08:47
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
This reverts commit 24ecf09.

Breaks the tests
@bdraco bdraco requested a review from springstan April 12, 2020 13:53
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 12, 2020

@springstan Thanks for the review!

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Of course 😄

@bdraco bdraco merged commit 5aca16e into home-assistant:dev Apr 12, 2020
@bdraco bdraco linked an issue Apr 14, 2020 that may be closed by this pull request
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homekit Setup Failed Homekit not responding

3 participants