Skip to content

Add changed_by to elkm1 alarm device_state_attributes#33982

Merged
bdraco merged 3 commits intohome-assistant:devfrom
bdraco:elk_changed_username
Apr 11, 2020
Merged

Add changed_by to elkm1 alarm device_state_attributes#33982
bdraco merged 3 commits intohome-assistant:devfrom
bdraco:elk_changed_username

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 10, 2020 •
edited
Loading

Proposed change

changed_by_entity_id was removed in 0.108 and replaced
with changed_by_keypad. This didn't provide enough
data to discover the last user that changed the alarm.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco
Add last_user_name to alarm device_state_attributes
534bf24 
changed_by_entity_id was removed in 0.108 and replaced
with changed_by_keypad.  This didn't provide enough
data to discover the last user that changed the alarm.
@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Apr 10, 2020

There's the changed_by property. Maybe use that instead?

https://developers.home-assistant.io/docs/entity_alarm_control_panel#properties

@bdraco
Switch to changed_by and restore since
ed8a1ea 
we loose the attributes on restart
@bdraco bdraco changed the title Add last_user_name to elkm1 alarm device_state_attributes Add changed_by to elkm1 alarm device_state_attributes Apr 11, 2020
MartinHjelmare
MartinHjelmare reviewed Apr 11, 2020
View reviewed changes
Comment thread homeassistant/components/elkm1/alarm_control_panel.py Outdated
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 11, 2020

retesting....

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 11, 2020

Screen_Shot_2020-04-10_at_8_53_05_PM

TEST PASS

MartinHjelmare
MartinHjelmare approved these changes Apr 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bdraco bdraco merged commit 44f8dab into home-assistant:dev Apr 11, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

by-code-owner cla-signed integration: elkm1 small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[elkm1] loss of changed_by_entity_id breaks automations

3 participants

@bdraco @MartinHjelmare @homeassistant