Skip to content

Exclude non thermostats from being detected by nexia#33979

Merged
springstan merged 1 commit into
home-assistant:devfrom
bdraco:nexia_exclude_non_thermostats
Apr 10, 2020
Merged

Exclude non thermostats from being detected by nexia#33979
springstan merged 1 commit into
home-assistant:devfrom
bdraco:nexia_exclude_non_thermostats

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 10, 2020

Proposed change

Exclude non thermostats from being detected by nexia

  • Fix detection of emergency heat

  • Bump nexia to 0.8.2

https://github.com/bdraco/nexia/blob/master/CHANGELOG.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* Fix detection of emergency heat

* Bump nexia to 0.8.2
@probot-home-assistant probot-home-assistant Bot added dependency Pull requests marked as a dependency upgrade integration: nexia small-pr PRs with less than 30 lines. labels Apr 10, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @ryannazaretian, mind taking a look at this pull request as its been labeled with a integration (nexia) you are listed as a codeowner for? Thanks!

@bdraco bdraco added this to the 0.108.3 milestone Apr 10, 2020
@springstan springstan merged commit 294a2d2 into home-assistant:dev Apr 10, 2020
balloob pushed a commit that referenced this pull request Apr 10, 2020
* Fix detection of emergency heat

* Bump nexia to 0.8.2
@balloob balloob mentioned this pull request Apr 10, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: nexia small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nexia Integration doesn't work with wireless sensors

4 participants