Skip to content

Add and use UNIT_DEGREE constant#33978

Merged
springstan merged 7 commits intohome-assistant:devfrom
springstan:add-and-use-UNIT_DEGREE-constant
Apr 11, 2020
Merged

Add and use UNIT_DEGREE constant#33978
springstan merged 7 commits intohome-assistant:devfrom
springstan:add-and-use-UNIT_DEGREE-constant

Conversation

@springstan
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Add and use UNIT_DEGREE constant by replacing the string occurrence in the code base.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare
Copy link
Copy Markdown
Member

Please solve the merge conflict.

Comment thread homeassistant/components/lcn/const.py Outdated
@springstan springstan merged commit b893150 into home-assistant:dev Apr 11, 2020
@springstan springstan deleted the add-and-use-UNIT_DEGREE-constant branch April 11, 2020 14:54
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants