Skip to content

Fix shutdown timeout and make it upstream with Supervisor#33973

Merged
pvizeli merged 3 commits into
devfrom
fix-shudown-timeout
Apr 10, 2020
Merged

Fix shutdown timeout and make it upstream with Supervisor#33973
pvizeli merged 3 commits into
devfrom
fix-shudown-timeout

Conversation

@pvizeli
Copy link
Copy Markdown
Member

@pvizeli pvizeli commented Apr 10, 2020

Breaking change

Proposed change

Default timeout for services are 3sec on S6-Overlay. Now we set it to the same timeout which the supervisor except.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added the small-pr PRs with less than 30 lines. label Apr 10, 2020
@pvizeli pvizeli added this to the 0.108.3 milestone Apr 10, 2020
Comment thread Dockerfile Outdated
@pvizeli pvizeli merged commit 14c35c9 into dev Apr 10, 2020
@delete-merged-branch delete-merged-branch Bot deleted the fix-shudown-timeout branch April 10, 2020 20:04
balloob pushed a commit that referenced this pull request Apr 10, 2020
* Fix shutdown timeout and make it upstream with Supervisor

* Moved ENV command up

* Update finish

Co-authored-by: Franck Nijhof <git@frenck.dev>
@balloob balloob mentioned this pull request Apr 10, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants