Skip to content

Restore some sensors that were removed from nut#33957

Closed
bdraco wants to merge 1 commit intohome-assistant:devfrom
bdraco:restore_sensors_nut
Closed

Restore some sensors that were removed from nut#33957
bdraco wants to merge 1 commit intohome-assistant:devfrom
bdraco:restore_sensors_nut

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 10, 2020

Proposed change

The following sensors were removed in 0.108 as they were provided by the device registry instead. Since there currently is no good way to display these in a card, restore the sensors.

  • ups.model
  • ups.mfr
  • ups.mfr.date
  • ups.serial
  • ups.vendorid
  • ups.productid
  • ups.firmware
  • ups.firmware.aux

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

The following sensors were removed in 0.108 have been restored

* ups.model
* ups.mfr
* ups.mfr.date
* ups.serial
* ups.vendorid
* ups.productid
* ups.firmware
* ups.firmware.aux
@bdraco bdraco added this to the 0.108.3 milestone Apr 10, 2020
@dshokouhi
Copy link
Copy Markdown
Member

I think a custom card may be required to display that data. ZHA had a similar issue where some data was only found in the UI and they created a ZHA network card that pulls in that data. I wonder if that should be done here? https://github.com/dmulcahey/zha-network-card IIRC they were asked to remove the zha entities that housed this data.

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 10, 2020

We shouldn't add this. Let me instead add a new entity row where people can decide themselves what text to show, so they can add it back manually. It's a static value anyway.

@balloob balloob removed this from the 0.108.3 milestone Apr 10, 2020
@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 10, 2020

Opened home-assistant/frontend#5516 instead.

@balloob balloob closed this Apr 10, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please do not remove ups.model from Nut in future versions.

4 participants