Skip to content

Fix powerwall units (kW)#33954

Merged
balloob merged 2 commits into
home-assistant:devfrom
bdraco:powerwall_units
Apr 10, 2020
Merged

Fix powerwall units (kW)#33954
balloob merged 2 commits into
home-assistant:devfrom
bdraco:powerwall_units

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 10, 2020 •
edited
Loading

Proposed change

Fix powerwall units (kW)

The scan interval was too low to detect power outages in a storm.

Minor cleanups to code (docstring, dupe const, etc)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added this to the 0.108.3 milestone Apr 10, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 10, 2020

Thanks @balloob

@balloob balloob merged commit ca0648a into home-assistant:dev Apr 10, 2020
balloob added a commit that referenced this pull request Apr 10, 2020
@bdraco @balloob
Fix powerwall units (kW) (#33954)
9bc04d7 
* Fix powerwall units (kW)

* Fix test

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@balloob balloob mentioned this pull request Apr 10, 2020
Merged
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

by-code-owner cherry-picked cla-signed integration: powerwall small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.108.3

Development

Successfully merging this pull request may close these issues.

Powerwall Integration has wrong units

4 participants

@bdraco @balloob @MartinHjelmare @homeassistant