Skip to content

Guard IPP against negative ink levels#33931

Merged
balloob merged 1 commit intohome-assistant:devfrom
ctalkington:ipp-level-guard
Apr 10, 2020
Merged

Guard IPP against negative ink levels#33931
balloob merged 1 commit intohome-assistant:devfrom
ctalkington:ipp-level-guard

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Apr 10, 2020

Breaking change

Proposed change

Printers with negative marker levels have special meanings. This prevents them from being considered as a percentage.

This would ideally be included in next 108 release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob added this to the 0.108.3 milestone Apr 10, 2020
@balloob balloob removed this from the 0.108.3 milestone Apr 10, 2020
@balloob balloob merged commit 2edfa82 into home-assistant:dev Apr 10, 2020
@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 10, 2020

Ran tests locally and passed.

balloob pushed a commit that referenced this pull request Apr 10, 2020
@balloob balloob mentioned this pull request Apr 10, 2020
@ctalkington ctalkington deleted the ipp-level-guard branch April 10, 2020 01:03
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPP returns ink level "-2" when printer is in standby/sleep/(Unavailable) mode

3 participants