Skip to content

Remove print() from Bayesian Binary Sensor#33916

Merged
springstan merged 1 commit intohome-assistant:devfrom
carlos-sarmiento:binary-sensor-print-remove
Apr 9, 2020
Merged

Remove print() from Bayesian Binary Sensor#33916
springstan merged 1 commit intohome-assistant:devfrom
carlos-sarmiento:binary-sensor-print-remove

Conversation

@carlos-sarmiento
Copy link
Copy Markdown
Contributor

Proposed change

Remove two spurious print statements (recently added and probably to help debugging) from the bayesian binary sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@springstan springstan merged commit d510384 into home-assistant:dev Apr 9, 2020
@carlos-sarmiento carlos-sarmiento deleted the binary-sensor-print-remove branch April 9, 2020 23:54
@balloob balloob modified the milestones: 0.108.3, 0.108.2 Apr 10, 2020
@balloob balloob mentioned this pull request Apr 10, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants