Skip to content

Fix Onvif Camera that does not have SnapshotUri such as Sricam #33902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Apr 10, 2020
Merged

Fix Onvif Camera that does not have SnapshotUri such as Sricam #33902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions homeassistant/components/onvif/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,11 @@ async def async_obtain_snapshot_uri(self):
req = media_service.create_type("GetSnapshotUri")
req.ProfileToken = profiles[self._profile_index].token

snapshot_uri = await media_service.GetSnapshotUri(req)
self._snapshot = snapshot_uri.Uri
try:
snapshot_uri = await media_service.GetSnapshotUri(req)
self._snapshot = snapshot_uri.Uri
except ServerDisconnectedError as err:
_LOGGER.debug("Camera does not support GetSnapshotUri: %s", err)
Comment on lines +414 to +418

@balloob balloob Apr 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ONVIFError different than ServerDisconnectedError ? What can still raise ONVIFError ?

@Minims Minims Apr 10, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need both exception. Here ServerDisconnectedErroris caught because the sever reset the connection. But if the onvif web server can answer but can't reply the right thing, it will raise ONVIFError as I understand.


_LOGGER.debug(
"ONVIF Camera Using the following URL for %s snapshot: %s",
Expand Down