Skip to content

Fix Doorbird yaml import aborted if discovery finds it first#33843

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:doorbird_zeroconf_race_not_imported
Apr 9, 2020
Merged

Fix Doorbird yaml import aborted if discovery finds it first#33843
balloob merged 1 commit intohome-assistant:devfrom
bdraco:doorbird_zeroconf_race_not_imported

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 8, 2020

Proposed change

There is a race condition in the config flow where discovery would find the doorbird before the import happened which would abort the import as the unique id was already set.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @oblogic7, mind taking a look at this pull request as its been labeled with a integration (doorbird) you are listed as a codeowner for? Thanks!

@bdraco bdraco added this to the 0.108.1 milestone Apr 8, 2020
@bdraco bdraco changed the title Doorbird not imported from yaml if discovery finds it first. Doorbird yaml import aborted if discovery finds it first. Apr 8, 2020
@MartinHjelmare MartinHjelmare changed the title Doorbird yaml import aborted if discovery finds it first. Fix Doorbird yaml import aborted if discovery finds it first Apr 9, 2020
@balloob balloob merged commit ff93630 into home-assistant:dev Apr 9, 2020
@balloob balloob mentioned this pull request Apr 9, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doorbird YAML configuration broken after upgrade to v0.108.0

4 participants