Skip to content

Fix nextcloud sensor mappings#33840

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
L-Henke:master
Apr 9, 2020
Merged

Fix nextcloud sensor mappings#33840
MartinHjelmare merged 1 commit intohome-assistant:devfrom
L-Henke:master

Conversation

@L-Henke
Copy link
Copy Markdown
Contributor

@L-Henke L-Henke commented Apr 8, 2020 •
edited
Loading

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

homeassistant commented Apr 8, 2020

Hi @L-Henke,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant Bot added integration: nextcloud merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Apr 8, 2020
@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Apr 8, 2020

Hey there @meichthys, mind taking a look at this pull request as its been labeled with a integration (nextcloud) you are listed as a codeowner for? Thanks!

@meichthys
Copy link
Copy Markdown
Contributor

meichthys commented Apr 8, 2020

@L-Henke thanks. Looks good to me.

meichthys
meichthys approved these changes Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@meichthys meichthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good.

@meichthys
Copy link
Copy Markdown
Contributor

meichthys commented Apr 9, 2020

@MartinHjelmare Would you be able to review this when you get a chance?

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Apr 9, 2020

Please rebase and target dev branch instead.

@L-Henke L-Henke changed the base branch from master to dev April 9, 2020 06:26
@meichthys
Copy link
Copy Markdown
Contributor

meichthys commented Apr 9, 2020

@L-Henke Thanks!
@MartinHjelmare I think we're all set.

@MartinHjelmare MartinHjelmare removed the merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. label Apr 9, 2020
MartinHjelmare
MartinHjelmare approved these changes Apr 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Fix sensor mappings Fix nextcloud sensor mappings Apr 9, 2020
@MartinHjelmare MartinHjelmare added this to the 0.108.2 milestone Apr 9, 2020
@MartinHjelmare MartinHjelmare merged commit 90f7cd2 into home-assistant:dev Apr 9, 2020
balloob pushed a commit that referenced this pull request Apr 10, 2020
@L-Henke @balloob
Fix nextcloud sensor mappings (#33840)
9efbf2f
@balloob balloob mentioned this pull request Apr 10, 2020
Merged
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

+1 more reviewer

@meichthys meichthys meichthys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-picked cla-signed integration: nextcloud small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.108.2

Development

Successfully merging this pull request may close these issues.

5 participants

@L-Henke @homeassistant @meichthys @MartinHjelmare @balloob