Skip to content

Update nut to use DataUpdateCoordinator#33831

Merged
balloob merged 3 commits intohome-assistant:devfrom
bdraco:nut_data_update
Apr 9, 2020
Merged

Update nut to use DataUpdateCoordinator#33831
balloob merged 3 commits intohome-assistant:devfrom
bdraco:nut_data_update

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 8, 2020

Proposed change

Update nut to use DataUpdateCoordinator

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 8, 2020

Rebase to fix build fail.

Comment thread homeassistant/components/nut/__init__.py Outdated
Comment thread homeassistant/components/nut/__init__.py Outdated
@bdraco bdraco force-pushed the nut_data_update branch 2 times, most recently from 8434779 to 0458e13 Compare April 8, 2020 21:28
Comment thread homeassistant/components/nut/config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 8, 2020

labeled testing required so it doesn't merge until I've had a chance to do a full run though

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 8, 2020

Import from yaml: OK
config flow with 1 upses: OK
config flow with 2 upses: OK
Dupe checking: OK

Should be good to go

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 8, 2020

Sorry about that TTS failure, I forgot to make a PR, did it now #33849

@bdraco bdraco force-pushed the nut_data_update branch from d85dc03 to 7b26fd6 Compare April 9, 2020 00:33
@balloob balloob merged commit 8be7cb4 into home-assistant:dev Apr 9, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants