Skip to content

Fix unhandled exception in Recollect Waste#33823

Merged
balloob merged 1 commit intohome-assistant:devfrom
bachya:recollect-scan-interval
Apr 8, 2020
Merged

Fix unhandled exception in Recollect Waste#33823
balloob merged 1 commit intohome-assistant:devfrom
bachya:recollect-scan-interval

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Apr 8, 2020

Proposed change

The recollect_waste integration overrode the sensor entity platform's SCAN_INTERVAL value with an int, which caused an unhandled exception further down the line. This PR switches that overridden value to a timedelta, which corrects the exception.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  - platform: recollect_waste
    place_id: !secret recollect_place_id
    service_id: !secret recollect_service_id

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bachya bachya self-assigned this Apr 8, 2020
@bachya bachya added this to the 0.108.1 milestone Apr 8, 2020
@bachya bachya force-pushed the recollect-scan-interval branch from bdb3b91 to 1ebfb91 Compare April 8, 2020 19:41
@balloob balloob merged commit 0b715b7 into home-assistant:dev Apr 8, 2020
@bachya bachya deleted the recollect-scan-interval branch April 8, 2020 19:52
@balloob balloob mentioned this pull request Apr 9, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recollect Waste log error on startup

3 participants