Improve Plex debounce/throttle logic#33805
Merged
MartinHjelmare merged 6 commits intohome-assistant:devfrom Apr 9, 2020
Merged
Improve Plex debounce/throttle logic#33805MartinHjelmare merged 6 commits intohome-assistant:devfrom
MartinHjelmare merged 6 commits intohome-assistant:devfrom
Conversation
Contributor
Author
|
Ended up ripping out the custom debouncer implementation and using the one from |
balloob
reviewed
Apr 8, 2020
balloob
approved these changes
Apr 8, 2020
jjlawren
force-pushed
the
plex_improve_debouncer
branch
from
a38e619 to
9776c78
Compare
balloob
pushed a commit
that referenced
this pull request
Apr 10, 2020
* Improve Plex debounce/throttle logic * Use Debouncer helper, rewrite affected tests * Mock storage so files aren't left behind * Don't bother with wrapper method, store debouncer call during init * Test cleanup from review * Don't patch own code in tests
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
I wasn't happy with the update debouncer implementation in #33560 as it would always add at least a 1s delay, and sometimes longer during very busy activity.
New logic:
EDIT: This functionality was already available in
homeassistant.helpers.debounce, so I ripped out the custom implementation and used the built-in class instead. (Thanks @balloob!)Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: