Fix slide open/close percentage#33739
Merged
Merged
Conversation
This was referenced Apr 6, 2020
Member
|
@ualex73 Would you please rebase so we can get a clean ci run https://developers.home-assistant.io/docs/development_catching_up/ |
Contributor
Author
|
@MartinHjelmare do i need (or should?) to do a rebase after you have approved the change? The CI seem to have failed, because of other components (not this component). |
Member
|
It was just the codecov upload that failed. I'll merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
This integration was previously using the (wrong) inverted percentage of open/close. Now we are according to the Home Assistant standards, which makes HomeKit working out of the box.
Proposed change
Fix the inverted percentage of open/close, as fallback a new option "invert_position" has been introduced. The offset of 5% to round it off as open/close has been extended to 15%.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: