Skip to content

Fix slide open/close percentage#33739

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
ualex73:slide-fix-percentage
Apr 9, 2020
Merged

Fix slide open/close percentage#33739
MartinHjelmare merged 3 commits into
home-assistant:devfrom
ualex73:slide-fix-percentage

Conversation

@ualex73
Copy link
Copy Markdown
Contributor

@ualex73 ualex73 commented Apr 6, 2020

Breaking change

This integration was previously using the (wrong) inverted percentage of open/close. Now we are according to the Home Assistant standards, which makes HomeKit working out of the box.

Proposed change

Fix the inverted percentage of open/close, as fallback a new option "invert_position" has been introduced. The offset of 5% to round it off as open/close has been extended to 15%.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

slide:
  username: YOUR_SLIDE_APP_USERNAME
  password: YOUR_SLIDE_APP_PASSWORD

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/slide/__init__.py Outdated
Comment thread homeassistant/components/slide/cover.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare changed the title Fix open/close percentage Fix slide open/close percentage Apr 7, 2020
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 8, 2020

@ualex73 Would you please rebase so we can get a clean ci run

https://developers.home-assistant.io/docs/development_catching_up/

@ualex73
Copy link
Copy Markdown
Contributor Author

ualex73 commented Apr 9, 2020

@MartinHjelmare do i need (or should?) to do a rebase after you have approved the change? The CI seem to have failed, because of other components (not this component).

@MartinHjelmare
Copy link
Copy Markdown
Member

It was just the codecov upload that failed. I'll merge now.

@MartinHjelmare MartinHjelmare merged commit 87e7e7f into home-assistant:dev Apr 9, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slide.io incorrect state in Apple HomeKit

4 participants