Skip to content

Add Direct Message support for Discord integration#33692

Merged
ludeeus merged 8 commits intodevfrom
unknown repository
Apr 9, 2020
Merged

Add Direct Message support for Discord integration#33692
ludeeus merged 8 commits intodevfrom
unknown repository

Conversation

@vermium
Copy link
Copy Markdown
Contributor

@vermium vermium commented Apr 5, 2020

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
notify:
  - platform: discord
    token: YOUR_DISCORD_BOT_TOKEN

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @vermium-sifell,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@vermium vermium changed the title Update notify.py Added Direct Message support for Discord integration Apr 5, 2020
@MartinHjelmare MartinHjelmare changed the title Added Direct Message support for Discord integration Add Direct Message support for Discord integration Apr 5, 2020
Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Apr 8, 2020

The current documentation only tells the user how to get the ID of a channel, not a user.
Please add a PR to update the documentation as well.

Also it doesn't state that user ID is supported.

@vermium
Copy link
Copy Markdown
Contributor Author

vermium commented Apr 9, 2020

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 9, 2020

How do you separate the user ID and the channel ID?
Can they collide?

@vermium
Copy link
Copy Markdown
Contributor Author

vermium commented Apr 9, 2020

Sorry for so much problems but here you go a good doc ig home-assistant/home-assistant.io#12771

@vermium
Copy link
Copy Markdown
Contributor Author

vermium commented Apr 9, 2020

How do you separate the user ID and the channel ID?
Can they collide?

I seperate them with an or function that takes them and test them as a channel / a user a id cant be a server channel and a user id at same time.

Added a comment
Comment thread homeassistant/components/discord/notify.py Outdated
@vermium vermium requested a review from ludeeus April 9, 2020 14:09
@ludeeus ludeeus merged commit c651ce0 into home-assistant:dev Apr 9, 2020
@fabaff fabaff mentioned this pull request Apr 11, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants