Add Direct Message support for Discord integration#33692
Conversation
Contributor
|
Hi @vermium-sifell, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Member
|
The current documentation only tells the user how to get the ID of a channel, not a user. Also it doesn't state that user ID is supported. |
8 tasks
ludeeus
approved these changes
Apr 9, 2020
8 tasks
Contributor
Author
Member
|
How do you separate the user ID and the channel ID? |
Contributor
Author
|
Sorry for so much problems but here you go a good doc ig home-assistant/home-assistant.io#12771 |
8 tasks
Contributor
Author
I seperate them with an or function that takes them and test them as a channel / a user a id cant be a server channel and a user id at same time. |
Added a comment
ludeeus
requested changes
Apr 9, 2020
ludeeus
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: