Add yamllint (in pre-commit and CI)#33676
Merged
springstan merged 4 commits intodevfrom Apr 5, 2020
Merged
Conversation
Member
Author
|
So the PR fails the tests (which I kinda expected to happen). Questions now: Added the requirements, also bumped it, realized I used an older version. |
Member
|
I like it! Everything that takes the guess work out of code review and formatting without significant pace impact is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add
yamllintto pre-commit and CI.I've adjusted all existing YAML files to make it pass.
It runs in under a second (all files) and in general use with pre-commit, it only triggers on changed YAML files.
This will help with keeping files formatted nicely, with a valid syntax and ensures they are YAML 1.2 compatible.
This PR is separated into 2 commits to make reviewing easier. One adding it, the second correcting existing YAML files.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: