Skip to content

Removal of old style class definitions in tests#33671

Merged
MartinHjelmare merged 1 commit intodevfrom
frenck-2020-0363
Apr 5, 2020
Merged

Removal of old style class definitions in tests#33671
MartinHjelmare merged 1 commit intodevfrom
frenck-2020-0363

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 4, 2020

Proposed change

Removal of old style class definitions in tests

class MyClass(object): -> class MyClass:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @ctalkington, mind taking a look at this pull request as its been labeled with a integration (roku) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @raman325, mind taking a look at this pull request as its been labeled with a integration (vizio) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare merged commit 262b01d into dev Apr 5, 2020
@MartinHjelmare MartinHjelmare deleted the frenck-2020-0363 branch April 5, 2020 00:21
@frenck frenck mentioned this pull request Apr 5, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants