Skip to content

Small code style improvements to Insteon integration#33662

Merged
frenck merged 2 commits intodevfrom
frenck-2020-0358
Apr 5, 2020
Merged

Small code style improvements to Insteon integration#33662
frenck merged 2 commits intodevfrom
frenck-2020-0358

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 4, 2020

Proposed change

Small Pythonic code style improvements to Insteon integration.
Originally came here to remove yields inside a for loop (replacing it with a yield from) and took up some other small adjustments as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/insteon/utils.py Outdated
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
@frenck frenck merged commit 61b4d1e into dev Apr 5, 2020
@frenck frenck deleted the frenck-2020-0358 branch April 5, 2020 00:58
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants