Skip to content

Enable pylint unnecessary-pass#33650

Merged
springstan merged 3 commits intodevfrom
frenck-2020-0352
Apr 5, 2020
Merged

Enable pylint unnecessary-pass#33650
springstan merged 3 commits intodevfrom
frenck-2020-0352

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 4, 2020

Proposed change

This PR enabled the unnecessary-pass Pylint rule.

I realize enabling this might be a little controversial and hit some people's opinions.

However, in the current situation, we would accept both unnecessary passes and without. This would at least make it standardized across the codebase and make it closer towards the "default" Pylint behavior.

Besides empty methods or classes, it also removes quite a few unnecessary passes in e.g., exception handling.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Just some additional clean up.

Comment thread homeassistant/components/adguard/config_flow.py Outdated
Comment thread homeassistant/components/fibaro/__init__.py Outdated
Comment thread homeassistant/components/openuv/config_flow.py Outdated
Comment thread homeassistant/components/plex/media_player.py Outdated
Comment thread homeassistant/components/plex/sensor.py Outdated
Comment thread homeassistant/components/tellduslive/binary_sensor.py Outdated
Comment thread homeassistant/components/tellduslive/cover.py Outdated
Comment thread homeassistant/components/tellduslive/light.py Outdated
Comment thread homeassistant/components/tellduslive/sensor.py Outdated
Comment thread homeassistant/components/tellduslive/switch.py Outdated
@frenck
Copy link
Copy Markdown
Member Author

frenck commented Apr 4, 2020

All processed.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@springstan springstan merged commit 7653dc9 into dev Apr 5, 2020
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2020-0352 branch April 5, 2020 08:33
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants