Purge recorder database at night#33646
Merged
balloob merged 2 commits intohome-assistant:devfrom Apr 16, 2020
Merged
Conversation
8 tasks
Member
|
4:12 is a great choice. 👍 Should we document this? |
Contributor
Author
|
I couldn't quite decide that. I kept it out of the documentation for now to give us some leeway for tweaks but I will go with whatever people want. |
This comment has been minimized.
This comment has been minimized.
Member
|
@BudBundi use |
Member
|
@amelchio I put some suggested language in the docs PR. |
balloob
reviewed
Apr 16, 2020
| ): cv.positive_int, | ||
| } | ||
| vol.Optional(DOMAIN, default=dict): vol.All( | ||
| cv.deprecated(CONF_PURGE_INTERVAL, invalidation_version="0.111.0"), |
Member
There was a problem hiding this comment.
Let's drop the invalidation_version. Let it be a warning and we can drop it at some point in the future. No reason to break things if we can keep it as a warning and it's not impacting operation.
Contributor
Author
There was a problem hiding this comment.
Done. Thank you for reviewing!
balloob
approved these changes
Apr 16, 2020
Member
|
Should we label this a breaking change? |
Contributor
Author
|
Yeah, sorry. I put the text in but I always forget about the label 🙄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
recorderconfigurationpurge_intervalhas been deprecated. The recorder database is now purged every night. This can be disabled with the newauto_purgeconfiguration though that is usually not recommended.Proposed change
This updates the recorder purge schedule as discussed in home-assistant/architecture#358.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: