-
-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Add Modbus cover #33642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Modbus cover #33642
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
be12f34
Add Modbus cover
vzahradnik 953dad0
Fix improper commands written for Modbus cover via coil
vzahradnik 0df27a4
Make changes per review comments
vzahradnik ecb614b
Fix default hub not defined
vzahradnik be1dc07
Move Cover config under Modbus section
vzahradnik 500462a
Revert setting up a default hub alias
vzahradnik 900e221
Make hub mandatory for Cover
vzahradnik 49092c9
Add default scan interval
vzahradnik a8cd0b3
Read scan_interval from discovery info
vzahradnik 30857f7
Fix linter error
vzahradnik 666855a
Use default scan interval from Cover platform
vzahradnik 638128d
Handle polling for Modbus cover directly inside entity
vzahradnik 202f096
Move covers under hub config
vzahradnik 97a8f90
Fix for review comment
vzahradnik ff84e8a
Call update() from Cover actuator methods
vzahradnik 013b071
Fix time validation
vzahradnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.