Skip to content

Handle race condition in harmony setup#33611

Merged
bdraco merged 5 commits intohome-assistant:devfrom
bdraco:harmony_config_flow_ssdp_race
Apr 4, 2020
Merged

Handle race condition in harmony setup#33611
bdraco merged 5 commits intohome-assistant:devfrom
bdraco:harmony_config_flow_ssdp_race

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 3, 2020

Proposed change

If the remote was discovered via ssdp before the yaml config import
happened, the unique id would already be set and the import
would abort.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

If the remote was discovered via ssdp before the yaml config import
happened, the unique id would already be set and the import
would abort.
@probot-home-assistant
Copy link
Copy Markdown

Hey there @ehendrix23, @bramkragten, mind taking a look at this pull request as its been labeled with a integration (harmony) you are listed as a codeowner for? Thanks!

@bdraco bdraco added this to the 0.108.0 milestone Apr 3, 2020
Comment thread homeassistant/components/harmony/config_flow.py Outdated
bdraco and others added 3 commits April 4, 2020 08:53
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
Comment thread homeassistant/components/harmony/config_flow.py
@bdraco bdraco merged commit 025cce3 into home-assistant:dev Apr 4, 2020
balloob added a commit that referenced this pull request Apr 5, 2020
* Handle race condition in harmony setup

If the remote was discovered via ssdp before the yaml config import
happened, the unique id would already be set and the import
would abort.

* Update homeassistant/components/harmony/config_flow.py

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* reduce

* black

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logitech Harmony Hub YAML config no longer working 0.108.0b0

4 participants