Skip to content

Use IP addresses instead of mDNS names when wled discovered#33608

Merged
balloob merged 1 commit intodevfrom
wled-zeroconf-use-ip
Apr 4, 2020
Merged

Use IP addresses instead of mDNS names when wled discovered#33608
balloob merged 1 commit intodevfrom
wled-zeroconf-use-ip

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 3, 2020

Breaking change

Proposed change

When WLED is discovered via zeroconf, use the IP address instead of the mDNS hostname when configuring WLED.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @frenck, mind taking a look at this pull request as its been labeled with a integration (wled) you are listed as a codeowner for? Thanks!

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @balloob 👍

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 3, 2020

Test failure is not related to this PR.

@balloob balloob merged commit c6ba607 into dev Apr 4, 2020
@balloob balloob deleted the wled-zeroconf-use-ip branch April 4, 2020 05:41
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants