Skip to content

Automatic: fix OAuth2 redirect#33581

Merged
balloob merged 1 commit intohome-assistant:devfrom
pbeckcom:patch-1
Apr 3, 2020
Merged

Automatic: fix OAuth2 redirect#33581
balloob merged 1 commit intohome-assistant:devfrom
pbeckcom:patch-1

Conversation

@pbeckcom
Copy link
Copy Markdown
Contributor

@pbeckcom pbeckcom commented Apr 3, 2020

Proposed change

Integration configuration cannot complete as it is currently looking for /states after authentication. Replacing with /lovelace to allow the script to complete after successful authentication with Automatic.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

I do not have the means to test locally.

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@pbeckcom
replaces /states with /lovelace in config script
afd4840 
Integration configuration cannot complete as it is currently looking for /states after authentication.  Replacing with /lovelace to allow the script to complete after successful authentication with Automatic.
@homeassistant
Copy link
Copy Markdown
Contributor

homeassistant commented Apr 3, 2020

Hi @pbeckcom,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant Bot added integration: automatic small-pr PRs with less than 30 lines. labels Apr 3, 2020
@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Apr 3, 2020

Hey there @armills, mind taking a look at this pull request as its been labeled with a integration (automatic) you are listed as a codeowner for? Thanks!

@pbeckcom
Copy link
Copy Markdown
Contributor Author

pbeckcom commented Apr 3, 2020

May resolve this issue; not enough details in issue to confirm.

@balloob balloob changed the title replaces /states with /lovelace in config script Automatic: fix OAuth2 redirect Apr 3, 2020
balloob
balloob approved these changes Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Automatic should really be converted to use our built-in OAuth2 helpers, none of this code would be needed.

@balloob balloob merged commit a813847 into home-assistant:dev Apr 3, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

cla-signed integration: automatic small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pbeckcom @homeassistant @balloob