Fix zeroconf discovery regression caused by upstream change#33572
Merged
Kane610 merged 1 commit intohome-assistant:devfrom Apr 3, 2020
Merged
Fix zeroconf discovery regression caused by upstream change#33572Kane610 merged 1 commit intohome-assistant:devfrom
Kane610 merged 1 commit intohome-assistant:devfrom
Conversation
|
Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration ( |
Member
Author
|
Please consider this for 0.108.0 as well as it is a fix for devices that were working with previous HA releases (0.24.4 zeroconf and earlier). |
Kane610
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
zeroconf 0.24.5 contained a regression that broke discovery for a bunch of devices. They have now reverted a change and 0.25.0 was released. See here.
They warned of a potentially backward incompatible change here. I don't believe it affects Home Assistant.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.The integration reached or maintains the following Integration Quality Scale: