Skip to content

Fix zeroconf discovery regression caused by upstream change#33572

Merged
Kane610 merged 1 commit intohome-assistant:devfrom
Jc2k:zeroconf_fix_browsing_regression
Apr 3, 2020
Merged

Fix zeroconf discovery regression caused by upstream change#33572
Kane610 merged 1 commit intohome-assistant:devfrom
Jc2k:zeroconf_fix_browsing_regression

Conversation

@Jc2k
Copy link
Copy Markdown
Member

@Jc2k Jc2k commented Apr 3, 2020

Proposed change

zeroconf 0.24.5 contained a regression that broke discovery for a bunch of devices. They have now reverted a change and 0.25.0 was released. See here.

They warned of a potentially backward incompatible change here. I don't believe it affects Home Assistant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added core integration: zeroconf small-pr PRs with less than 30 lines. dependency Pull requests marked as a dependency upgrade labels Apr 3, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

@Jc2k Jc2k added this to the 0.108.0 milestone Apr 3, 2020
@Jc2k
Copy link
Copy Markdown
Member Author

Jc2k commented Apr 3, 2020

Please consider this for 0.108.0 as well as it is a fix for devices that were working with previous HA releases (0.24.4 zeroconf and earlier).

@Kane610 Kane610 merged commit 730d90f into home-assistant:dev Apr 3, 2020
balloob pushed a commit that referenced this pull request Apr 3, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
@Jc2k Jc2k deleted the zeroconf_fix_browsing_regression branch August 18, 2020 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed core dependency Pull requests marked as a dependency upgrade integration: zeroconf small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants