Change the method of getting the mac address in the braviatv integration#33567
Merged
balloob merged 3 commits intohome-assistant:devfrom Apr 4, 2020
bieniu:bravia-remove-getmac
Merged
Change the method of getting the mac address in the braviatv integration#33567balloob merged 3 commits intohome-assistant:devfrom bieniu:bravia-remove-getmac
balloob merged 3 commits intohome-assistant:devfrom
bieniu:bravia-remove-getmac
Conversation
probot-home-assistant
Bot
added
integration: braviatv
small-pr
|
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( |
Member
Author
|
@dcnielsen90 Could you take a look? |
springstan
added
dependency
springstan
approved these changes
Apr 3, 2020
Member
springstan
left a comment
springstan
left a comment
There was a problem hiding this comment.
LGTM 👍 just one question about this change
springstan
reviewed
Apr 3, 2020
Member
Author
|
@springstan I've tested everything once again and now the code catches every exception and problem. |
springstan
approved these changes
Apr 3, 2020
Member
springstan
left a comment
springstan
left a comment
There was a problem hiding this comment.
Looks good! Thanks @bieniu for taking the time and improving the stability of this integration 👍
springstan
added
integration: braviatv
and removed
integration: braviatv
integration: braviatv
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
None
Proposed change
Currently, integration use
getmaclibrary to getmacaddress.With change from this PR the integration uses the
get_system_infomethod from thebravia-tvlibrary to get themacaddress.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: