Fix source attribute value for braviatv integration#33565
Merged
springstan merged 1 commit intohome-assistant:devfrom Apr 3, 2020
bieniu:bravia-sources
Merged
Fix source attribute value for braviatv integration#33565springstan merged 1 commit intohome-assistant:devfrom bieniu:bravia-sources
springstan merged 1 commit intohome-assistant:devfrom
bieniu:bravia-sources
Conversation
|
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( |
Member
Author
|
@dcnielsen90 Could you take a look? |
Contributor
|
Cool, just tested and looks good to me 👍 |
dcnielsen90
approved these changes
Apr 3, 2020
springstan
approved these changes
Apr 3, 2020
Member
There was a problem hiding this comment.
Looks good to me as well!
@bieniu should we include this in the beta as well? 😁
Member
Author
|
@springstan Yes, of course 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
None
Proposed change
Currently, the
sourceattribute of the entity is outside thesource_list. For example, on my TV,source_listisHDMI 1, HDMI 2, HDMI 3/ARC, HDMI 4, AV/Componentandsourcehas valueextInput:hdmi.This PR changes the method of detecting the
source. Based on the valueuriselects the appropriatesourcefrom thesource_list.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: