Skip to content

Fix source attribute value for braviatv integration#33565

Merged
springstan merged 1 commit intohome-assistant:devfrom
bieniu:bravia-sources
Apr 3, 2020
Merged

Fix source attribute value for braviatv integration#33565
springstan merged 1 commit intohome-assistant:devfrom
bieniu:bravia-sources

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Apr 3, 2020

Breaking change

None

Proposed change

Currently, the source attribute of the entity is outside the source_list. For example, on my TV, source_list is HDMI 1, HDMI 2, HDMI 3/ARC, HDMI 4, AV/Component and source has value extInput:hdmi.

This PR changes the method of detecting the source. Based on the value uri selects the appropriate source from the source_list.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (braviatv) you are listed as a codeowner for? Thanks!

@bieniu
Copy link
Copy Markdown
Member Author

bieniu commented Apr 3, 2020

@dcnielsen90 Could you take a look?

@dcnielsen90
Copy link
Copy Markdown
Contributor

Cool, just tested and looks good to me 👍

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!
@bieniu should we include this in the beta as well? 😁

@bieniu
Copy link
Copy Markdown
Member Author

bieniu commented Apr 3, 2020

@springstan Yes, of course 😄

@springstan springstan added this to the 0.108.0 milestone Apr 3, 2020
@springstan springstan merged commit c0315e3 into home-assistant:dev Apr 3, 2020
@bieniu bieniu deleted the bravia-sources branch April 3, 2020 14:52
balloob pushed a commit that referenced this pull request Apr 3, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants