Skip to content

Identify cameras in error logs for generic and mjpeg#33561

Merged
springstan merged 1 commit intohome-assistant:devfrom
azogue:fix/identify-cameras-on-logs
Apr 3, 2020
Merged

Identify cameras in error logs for generic and mjpeg#33561
springstan merged 1 commit intohome-assistant:devfrom
azogue:fix/identify-cameras-on-logs

Conversation

@azogue
Copy link
Copy Markdown
Member

@azogue azogue commented Apr 3, 2020

TimeOut and ClientError failures on generic and mjpeg cameras are not identifying the camera entities that fail, making it hard to know which is failing if more than one are in use.

Breaking change

Proposed change

Add the camera name on these error logs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
camera:
- platform: generic
  # ...

- platform: mjpeg
  # ...

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

and homogenize log messages in both.
@springstan springstan merged commit d1c1aa5 into home-assistant:dev Apr 3, 2020
@springstan
Copy link
Copy Markdown
Member

Tagging this for beta because no functionality has changed and only the log details have been improved.

@springstan springstan added this to the 0.108.0 milestone Apr 3, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants