Skip to content

Plex followup to #33542#33558

Merged
balloob merged 1 commit intohome-assistant:devfrom
jjlawren:followup_33542
Apr 3, 2020
Merged

Plex followup to #33542#33558
balloob merged 1 commit intohome-assistant:devfrom
jjlawren:followup_33542

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Apr 3, 2020

Proposed change

Style followup to use own constants from #33542 review comments.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@jjlawren jjlawren mentioned this pull request Apr 3, 2020
20 tasks
@jjlawren jjlawren added this to the 0.108.0 milestone Apr 3, 2020
@balloob balloob merged commit d98171e into home-assistant:dev Apr 3, 2020
balloob pushed a commit that referenced this pull request Apr 3, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
@jjlawren jjlawren deleted the followup_33542 branch April 5, 2020 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants