Skip to content

Add missing flow_title to doorbird#33557

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:doorbird_missing_flow_title_has_placeholders
Apr 3, 2020
Merged

Add missing flow_title to doorbird#33557
balloob merged 1 commit intohome-assistant:devfrom
bdraco:doorbird_missing_flow_title_has_placeholders

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 3, 2020

Proposed change

When placeholders are in use, flow_title needs to be
set in the json to prevent an empty name in the
integrations dashboard. This affected doorbirds
that were found via ssdp.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

When placeholders are in use, flow_title needs to be
set in the json to prevent an empty name in the
integrations dashboard. This affected doorbirds
that were found via ssdp.
@probot-home-assistant
Copy link
Copy Markdown

Hey there @oblogic7, mind taking a look at this pull request as its been labeled with a integration (doorbird) you are listed as a codeowner for? Thanks!

@bdraco bdraco added this to the 0.108.0 milestone Apr 3, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 3, 2020

Screen_Shot_2020-04-02_at_8_43_05_PM

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 3, 2020

After
Screen_Shot_2020-04-02_at_8_44_13_PM

@balloob balloob merged commit d2cd557 into home-assistant:dev Apr 3, 2020
balloob pushed a commit that referenced this pull request Apr 3, 2020
When placeholders are in use, flow_title needs to be
set in the json to prevent an empty name in the
integrations dashboard. This affected doorbirds
that were found via ssdp.
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants