Rachio Async fixes

[brg468]

Proposed change

Fix Rachio functions

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @bdraco, mind taking a look at this pull request as its been labeled with a integration (rachio) you are listed as a codeowner for? Thanks!

[brg468]

@MartinHjelmare let me know what I messed up

[MartinHjelmare]

Please also rename state_attributes property to device_state_attributes in RachioZone class.

[MartinHjelmare]

There was some legacy code that I've commented on too now.

[brg468]

Ill push the rest of the changes later.

Thanks @bdraco !

[bdraco]

I'll retest after dinner

[bdraco]

LGTM

[brg468]

@bdraco. I should have let you handle this one 😄. I’m thinking I’m out of my element here. Lint is failing on undo_dispatcher.

Do we still need this?

async def async_will_remove_from_hass(self):
        """Unsubscribe from updates."""
        if self._undo_dispatcher:
            self._undo_dispatcher()

[bdraco]

@bdraco. I should have let you handle this one 😄. I’m thinking I’m out of my element here. Lint is failing on undo_dispatcher.

Do we still need this?

async def async_will_remove_from_hass(self):
        """Unsubscribe from updates."""
        if self._undo_dispatcher:
            self._undo_dispatcher()

Its not needed anymore since the self.async_on_remove( wrapping is doing that

[brg468]

That was my guess but wasn’t sure. Thanks again 👍

[bdraco]

That was my guess but wasn’t sure. Thanks again 👍

Here is what is going on under the hood
homeassistant/helpers/entity.py

    @callback
    def async_on_remove(self, func: CALLBACK_TYPE) -> None:
        """Add a function to call when entity removed."""
        if self._on_remove is None:
            self._on_remove = []
        self._on_remove.append(func)

    async def async_remove(self) -> None:
        """Remove entity from Home Assistant."""
        assert self.hass is not None
        await self.async_internal_will_remove_from_hass()
        await self.async_will_remove_from_hass()

        if self._on_remove is not None:
            while self._on_remove:
                self._on_remove.pop()()

[brg468]

Thanks again! I'm fairly new to this and I obviously have a lot left to learn. I don't have any more PR's in the works for a while 😄.

[bdraco]

Thanks again! I'm fairly new to this and I obviously have a lot left to learn. I don't have any more PR's in the works for a while 😄.

The code base is still under heavy development and we are all learning. Happy to review more PRs if you do come up with more!

[bdraco]

Tested schedules, flex schedules, on/off via app and via home assistant.
Tested setting up config flow
Tested removing integration

TEST PASS

[bdraco]

Thanks again! I'm fairly new to this and I obviously have a lot left to learn. I don't have any more PR's in the works for a while 😄.

If you are feeling ambitious and want to do a new PR, binary_sensor.py has many of the same issues that your just fixed !