Skip to content

update to pyipp==0.8.2#33544

Merged
springstan merged 3 commits intohome-assistant:devfrom
ctalkington:patch-1
Apr 2, 2020
Merged

update to pyipp==0.8.2#33544
springstan merged 3 commits intohome-assistant:devfrom
ctalkington:patch-1

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Apr 2, 2020

Proposed change

improves handling of missing device id on some printers

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added integration: ipp small-pr PRs with less than 30 lines. dependency Pull requests marked as a dependency upgrade by-code-owner labels Apr 2, 2020
@ctalkington
Copy link
Copy Markdown
Contributor Author

this should be picked into 108

@springstan
Copy link
Copy Markdown
Member

Failing CI is not related to this change.

@springstan springstan merged commit b719a77 into home-assistant:dev Apr 2, 2020
@ctalkington ctalkington deleted the patch-1 branch April 2, 2020 23:23
balloob pushed a commit that referenced this pull request Apr 3, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: ipp small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants