Skip to content

Ensure harmony hub is ready before importing#33537

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:harmony_retry_import_platform_not_ready
Apr 2, 2020
Merged

Ensure harmony hub is ready before importing#33537
balloob merged 1 commit intohome-assistant:devfrom
bdraco:harmony_retry_import_platform_not_ready

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 2, 2020

Proposed change

If the harmony hub was not ready for connection or
was busy when importing from yaml, the import validation
would fail would not be retried.

To mitigate this scenario we now do the validation in
async_setup_platform which allows us to raise
PlatformNotReady so we can retry later.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

If the harmony hub was not ready for connection or
was busy when importing from yaml, the import validation
would fail would not be retried.

To mitigate this scenario we now do the validation in
async_setup_platform which allows us to raise
PlatformNotReady so we can retry later.
@probot-home-assistant
Copy link
Copy Markdown

Hey there @ehendrix23, @bramkragten, mind taking a look at this pull request as its been labeled with a integration (harmony) you are listed as a codeowner for? Thanks!

@bdraco bdraco added this to the 0.108.0 milestone Apr 2, 2020
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@balloob balloob merged commit 590e714 into home-assistant:dev Apr 2, 2020
balloob pushed a commit that referenced this pull request Apr 3, 2020
If the harmony hub was not ready for connection or
was busy when importing from yaml, the import validation
would fail would not be retried.

To mitigate this scenario we now do the validation in
async_setup_platform which allows us to raise
PlatformNotReady so we can retry later.
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logitech Harmony Hub YAML config no longer working 0.108.0b0

3 participants