Remove MQTT state vacuum value_template support.

[emontnemery]

Proposed change

Remove MQTT state vacuum value_template support.
The implementation is not working, so this can not be considered a breaking change.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

[emontnemery]

@pszafer Please review if you have time.

[pszafer]

I found one repo which uses string as state
https://github.com/mannkind/ESPHomeRoombaComponent/blob/master/ESPHomeRoombaComponent.h

but I think it couldn't work as author of this repo expected.

[emontnemery]

@pszafer I think the code in your example won't be affected by this PR.
This code:
https://github.com/mannkind/ESPHomeRoombaComponent/blob/af753cd7210d1be600c4bb5ac0cd0a200f405d8b/ESPHomeRoombaComponent.h#L138-L142

Seems well aligned with the state vacuum MQTT schema without a value_template here: https://www.home-assistant.io/integrations/vacuum.mqtt/#state-mqtt-protocol

[balloob]

What happens if JSON parsing fails?

[balloob]

We don't allow templates to render JSON that needs to be parsed.

[balloob]

We don't allow templates to render JSON that needs to be parsed.

[emontnemery]

@balloob The payload expected on the state_topic is a valid JSON dict, and the output of a template is always a string so the template must render JSON. What's the problem with parsing the output?

This is similar to https://www.home-assistant.io/integrations/sensor.mqtt/#json-attributes-template-configuration.

Since the current implementation of the value_template for MQTT state vacuum is broken, another option would be to just remove the configuration option.

[emontnemery]

This is the implementation of json_attributes_template:

core/homeassistant/components/mqtt/__init__.py

Lines 1063 to 1079 in b10319f

	@callback
	@log_messages(self.hass, self.entity_id)
	def attributes_message_received(msg: Message) -> None:
	try:
	payload = msg.payload
	if attr_tpl is not None:
	payload = attr_tpl.async_render_with_possible_json_value(payload)
	json_dict = json.loads(payload)
	if isinstance(json_dict, dict):
	self._attributes = json_dict
	self.async_write_ha_state()
	else:
	_LOGGER.warning("JSON result was not a dictionary")
	self._attributes = None
	except ValueError:
	_LOGGER.warning("Erroneous JSON: %s", payload)
	self._attributes = None

[emontnemery]

PR updated to remove state_template support instead.