Add Rachio Flex Schedules#33533
Conversation
|
Looks good, I'll have some time to test tonight |
|
Just tested, flex schedules are not showing up. |
|
Disregard: I missed the merge conflict so it wasn't up to date. (testing error on my part) |
|
Verified ok running from app -> shows in Home Assistant |
|
Ha phew! I just built a new schedule to test and it was there so I was about to be real confused. |
|
Verified turning off in app shows in Home Assistant |
|
Verified on in home assistant show on in app |
|
Verified off in home assistant show on in app |
|
TEST PASS |
👍 |
|
|
||
| def _handle_update(self, *args, **kwargs) -> None: | ||
| @callback | ||
| async def _handle_update(self, *args, **kwargs) -> None: |
There was a problem hiding this comment.
A coroutine function can't be a callback.
- Please remove the
asyncinasync def. - Rename the function to
_async_handle_update. - Change
self.schedule_update_ha_statetoself.async_write_ha_stateinside. - Do this for all the switch classes and the abstract method.
- Rename
_handle_any_updatetoo, similarly. - Decorate all these methods with
@callback.
There was a problem hiding this comment.
Thanks @MartinHjelmare
@brg468 Do you want to do a PR for this?, or I can take care of it needed.
There was a problem hiding this comment.
If you had any other changes you were planning go ahead, if not I can do it in a bit.
There was a problem hiding this comment.
I'm working on fixing something in homekit so you'll probably get to it before I do.
Proposed change
Add Rachio Flex Schedules as switches.
Follow-up to #33421
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: