Skip to content

Update pyotgw to 0.6b1#33529

Merged
balloob merged 1 commit intohome-assistant:devfrom
mvn23:otgw-lib-update
Apr 2, 2020
Merged

Update pyotgw to 0.6b1#33529
balloob merged 1 commit intohome-assistant:devfrom
mvn23:otgw-lib-update

Conversation

@mvn23
Copy link
Copy Markdown
Contributor

@mvn23 mvn23 commented Apr 2, 2020

Proposed change

Update pyotgw to 0.6b1.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

#32408 added support for availability, but required a library update to complete that support. This PR provides the required update.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added integration: opentherm_gw small-pr PRs with less than 30 lines. dependency Pull requests marked as a dependency upgrade by-code-owner labels Apr 2, 2020
@springstan
Copy link
Copy Markdown
Member

Please solve the failing CI checks :)

@mvn23 mvn23 force-pushed the otgw-lib-update branch from 5294fc8 to 27610a1 Compare April 2, 2020 14:56
@mvn23 mvn23 force-pushed the otgw-lib-update branch from 27610a1 to ac7f6bd Compare April 2, 2020 15:37
@mvn23
Copy link
Copy Markdown
Contributor Author

mvn23 commented Apr 2, 2020

After the initial oops, all's well now.

@springstan
Copy link
Copy Markdown
Member

@mvn23 should we tag this for 0.108?

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 2, 2020

Please include a change log of what has changed when upgrading dependencies.

@mvn23
Copy link
Copy Markdown
Contributor Author

mvn23 commented Apr 2, 2020

This should not be released without #32408 which was merged into dev earlier today. If that one made it into 0.108, this one can be included as well. I'm not up to date on the merge window for 0.108, sorry.

Please include a change log of what has changed when upgrading dependencies.

Main changes since 0.5b1:

  • General code cleanup and linting
  • Fixed commands when not connected to the gateway
  • Add debug logging when connection is lost
  • Send empty report on connection loss
  • Make serial writes non-blocking
  • Clean up after unfinished connection attempt when disconnecting/reconnecting

@balloob balloob merged commit 1d89d22 into home-assistant:dev Apr 2, 2020
@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 2, 2020

108 was cut yesterday, so this will be for 109.

@mvn23 mvn23 deleted the otgw-lib-update branch April 2, 2020 23:43
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: opentherm_gw small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants