Fix netatmo device unavailable and services#33509
Merged
MartinHjelmare merged 8 commits intohome-assistant:devfrom Apr 2, 2020
Merged
Fix netatmo device unavailable and services#33509MartinHjelmare merged 8 commits intohome-assistant:devfrom
MartinHjelmare merged 8 commits intohome-assistant:devfrom
Conversation
cgtobi
force-pushed
the
netatmo_climate_bugfix
branch
from
f494d81 to
828c77c
Compare
MartinHjelmare
changed the title
MartinHjelmare
requested changes
Apr 2, 2020
Member
|
Test failures are unrelated (tts). Merging. |
balloob
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Handle unavailabe entities * Remove some logging * Set valve to lowest temp when turned off * Remove some logging * Address comments * Report entity as connected if update is successful * Fix stupidness * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This will set the entity as unavailable when errors occur that imply that the device is out of reach or its batteries died.
It also fixes an issue with turn_on/off services not working correctly. Since valves can't be turned off they will be set to the lowest setting.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: