Fix asuswrt network failure startup#33485
Merged
MartinHjelmare merged 22 commits intohome-assistant:devfrom Apr 3, 2020
Merged
Fix asuswrt network failure startup#33485MartinHjelmare merged 22 commits intohome-assistant:devfrom
MartinHjelmare merged 22 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
integration: asuswrt
small-pr
Contributor
|
Hey there @kennedyshead, mind taking a look at this pull request as its been labeled with a integration ( |
frenck
reviewed
Apr 1, 2020
kennedyshead
reviewed
Apr 1, 2020
MartinHjelmare
changed the title
MartinHjelmare
requested changes
Apr 2, 2020
Align to master
Fix for issue #home-assistant#33284 - Asuswrt component fail at startup after power failure
This reverts commit a2ccdda.
ollo69
force-pushed
the
asuswrt-startup-fix
branch
from
2ea8e52 to
9b5d9e8
Compare
balloob
approved these changes
Apr 2, 2020
bdraco
requested changes
Apr 3, 2020
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
Looks like the test_specify_non_directory_path_for_dnsmasq test is failing
MartinHjelmare
requested changes
Apr 3, 2020
MartinHjelmare
approved these changes
Apr 3, 2020
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Good!
There is potential for making the tests more robust. That can be a future PR.
| hass, DOMAIN, {DOMAIN: {CONF_HOST: "fake_host", CONF_USERNAME: "fake_user"}} | ||
| ) | ||
| assert result | ||
| assert hass.data.get(DATA_ASUSWRT, None) is None |
Member
There was a problem hiding this comment.
It would be better if we tested the existence of states in the state machine. When there's an error there shouldn't be any states. After the error clears, the setup should complete and states be created. That way we don't rely on the details of our implementation in the tests.
Contributor
Author
There was a problem hiding this comment.
Ok, I will keeep in consideration for next PR. Thx
balloob
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Fix network failure startup Fix for issue ##33284 - Asuswrt component fail at startup after power failure * Removed comment * Removed bare except * is_connected moved out try-catch * Removed pointless-string-statement * Raise PlatformNotReady on "not is_connected" * Removed unnecessary check * Revert "Removed unnecessary check" This reverts commit a2ccdda. * Implemented custom retry mechanism * Fix new line missing * Fix formatting * Fix indent * Reviewed check * Recoded based on tibber implementation * Formatting review * Changes requested * Fix tests for setup retry * Updated missing test * Fixed check on Tests * Return false if not exception * Format correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix for issue ##33284 - Asuswrt component fail at startup after power failure.
Manage exception during component initialization and raise "PlatformNotReady if exception is type "OSError" (typically will be: [Errno 101] Network is unreachable)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: