Skip to content

Apply recommendations from IPP review#33477

Merged
balloob merged 3 commits intohome-assistant:devfrom
ctalkington:ipp-review
Mar 31, 2020
Merged

Apply recommendations from IPP review#33477
balloob merged 3 commits intohome-assistant:devfrom
ctalkington:ipp-review

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Mar 31, 2020

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added has-tests small-pr PRs with less than 30 lines. labels Mar 31, 2020
@ctalkington ctalkington changed the title WIP: Apply recommendations from IPP review Apply recommendations from IPP review Mar 31, 2020
@balloob balloob merged commit 83fb5e5 into home-assistant:dev Mar 31, 2020
@ctalkington ctalkington deleted the ipp-review branch April 1, 2020 01:18
@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants