Add MQTT debug info#33461
Merged
balloob merged 3 commits intohome-assistant:devfrom Apr 1, 2020
Merged
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
9 tasks
balloob
reviewed
Mar 31, 2020
Comment on lines
+25
to
+26
| if len(messages) >= STORED_MESSAGES: | ||
| messages.pop(0) |
Contributor
Author
There was a problem hiding this comment.
I did initally, but a deque can't be serialized as JSON so this was the lazy way out. Will look again.
Member
There was a problem hiding this comment.
We are more often adding messages than serializing to JSON.
balloob
reviewed
Mar 31, 2020
| check_func = check_func.func | ||
|
|
||
| wrapper_func = None | ||
| if asyncio.iscoroutinefunction(check_func): |
Member
There was a problem hiding this comment.
Is this necessary, are there any that are coroutines ?
Contributor
Author
There was a problem hiding this comment.
No, it's not really necessary, none of the native MQTT integrations have coroutine callbacks.
Should I just remove this case?
balloob
reviewed
Mar 31, 2020
| DATA_MQTT_DEBUG_INFO, {"entities": {}, "triggers": {}} | ||
| ) | ||
| for entry in entries: | ||
| if entry.entity_id in mqtt_debug_info["entities"]: |
Member
There was a problem hiding this comment.
Make this a guard clause. if x not in y: continue
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add WS command to fetch MQTT debug info for an MQTT device:
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: