Skip to content

Ignore link local addresses during doorbird ssdp config flow#33401

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:doorbird_link_local
Mar 31, 2020
Merged

Ignore link local addresses during doorbird ssdp config flow#33401
balloob merged 1 commit intohome-assistant:devfrom
bdraco:doorbird_link_local

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 29, 2020

Proposed change

Ignore link local addresses during doorbird ssdp config flow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @oblogic7, mind taking a look at this pull request as its been labeled with a integration (doorbird) you are listed as a codeowner for? Thanks!

Comment thread homeassistant/components/doorbird/config_flow.py
Comment thread tests/components/doorbird/test_config_flow.py
@balloob balloob merged commit a473ae6 into home-assistant:dev Mar 31, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants